Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified code for DispatchQoS.QoSClass.description and qos_class_t.description #137

Merged
merged 2 commits into from
May 21, 2019
Merged

Unified code for DispatchQoS.QoSClass.description and qos_class_t.description #137

merged 2 commits into from
May 21, 2019

Conversation

RomanPodymov
Copy link
Contributor

Hello.
In this pull request I added QoSClassDescription to unify strings in DispatchQoS.QoSClass.description and qos_class_t.description.
I also removed get in these computed properties.
Please rename QoSClassDescription and propose a better description for it if you want.

@duemunk
Copy link
Owner

duemunk commented May 21, 2019

Looks good. Maybe the enum can be private?

@duemunk duemunk merged commit 1d67539 into duemunk:master May 21, 2019
@duemunk
Copy link
Owner

duemunk commented May 21, 2019

🙏

@RomanPodymov RomanPodymov deleted the feature/qos_class_description branch May 21, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants